[codex] Structure Electron protocol teardown failures#3310
Merged
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved Straightforward error handling improvement that wraps protocol unregistration failures in a structured error class, matching the existing pattern for registration errors. The change is self-contained with good test coverage and minimal runtime impact. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
vp test apps/desktop/src/electron/ElectronProtocol.test.tsvp checkvp run typecheckOverlap audit
apps/desktop/src/electron/ElectronProtocol.tsalso appears in unrelated local-auth startup PR fix: stabilize local dev auth startup #3252; no active error-audit PR touches this module.Note
Structure Electron protocol teardown failures into typed errors
ElectronProtocolUnregistrationErrorto capture failures fromElectron.protocol.unhandle, preserving the scheme and original cause.acquireReleaseteardown inregisterDesktopProtocolto useEffect.tryinstead ofEffect.sync, wrapping thrown exceptions in the new error type and terminating viaorDie.ElectronProtocolRegistrationErrormessage format toFailed to register Electron protocol scheme "<scheme>".Macroscope summarized dda508c.